-
Notifications
You must be signed in to change notification settings - Fork 239
chore: migrate workflows from circleci to github actions [SWC-767] #5222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 14133318326Details
💛 - Coveralls |
66d98a6 to
58e620f
Compare
5b787ac to
3b647fc
Compare
3b647fc to
8c5b757
Compare
9a4bad9 to
ece6ce1
Compare
587188a to
9579b34
Compare
9579b34 to
a1497f9
Compare
1743afb to
f7eb6b8
Compare
f7eb6b8 to
3363b2a
Compare
Description
Due to some spottiness and difficulty throughout the team debugging CircleCI, this pull request migrations a few low-impact tasks to GitHub Actions using a format that is already validated to be working in Spectrum CSS.
and Windows. This also ensures no uncommitted changes arise from the build task.development.ymlthat runs on pull requests and pushes. It validates the build in each supported env, checks test coverage, and runs linting.How has this been tested?
Setup:
Create a fork branch off this one:
git checkout -b test-circleci-migrationValidate stylelint plugin
packages/accordion/src/accordion.csswith:host { --spectrum-logical-rotation: ; --spectrum-logical-rotation: ; }(duplicate variable intentional)git commit --no-verify -m "break styles"Validate eslint plugin
packages/accordion/src/Accordion.tswithimport { css, CSSResultArray, html, PropertyValues, SizedMixin, SpectrumElement, TemplateResult, } from '@spectrum-web-components/base';git commit --no-verify -m "break typescript"To validate the above, open a pull request for the test branch update against main and let CI do its thing.
Expect a comment to be added to the pull request reporting the errors in this update
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.