chore: update dependency @spectrum-css/typography to v8.1.0 #5295
Conversation
🦋 Changeset detectedLatest commit: 6ef7a90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
renovate
bot
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
6 times, most recently
from
b364818 to
918f1d2
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
castastrophe
changed the title
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
| try { | ||
| sourceCSS = fs.readFileSync(sourcePath, 'utf-8'); | ||
| } catch (error) { |
There was a problem hiding this comment.
Try catch is not an optimal way to check if a file exists - swapped this for fs.existsSync
| */ | ||
|
|
||
| import baseStyles from './src/spectrum-base.css.js'; | ||
| import langBaseStyles from './src/spectrum-lang.css.js'; |
There was a problem hiding this comment.
None of the *-overrides files were necessary for typography so this reduces that complexity. Note the files are not removed because they're being shipped in the exports object and thus could be used by customers downstream without us knowing. The files will now be empty but present.
Tachometer resultsCurrently, no packages are changed by this PR... |
|
|
||
| const processTypography = async ( | ||
| baseSrcPath, | ||
| overridesSrcPath, |
There was a problem hiding this comment.
No overrides are needed for the typography package anymore.
castastrophe
added
Status: Ready for review
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
2 times, most recently
from
5c8beb2 to
a9416d6
Compare
|
These updates are covered by the changeset: |
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
8 times, most recently
from
8fb39e2 to
fd47c81
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
3 times, most recently
from
c83202c to
08fdd18
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
3 times, most recently
from
c8a530f to
d1901c3
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
from
d1901c3 to
8cfc8d1
Compare
|
@castastrophe does this one fall in with the other CSS dependency work on going? i know this ships differently than components, so if it needs a review let me know and ill hop on it :) |
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
4 times, most recently
from
0f3a820 to
7695f7b
Compare
| import '@spectrum-web-components/popover/sp-popover.js'; | ||
| import '@spectrum-web-components/divider/sp-divider.js'; | ||
| import cardStyles from './card.css.js'; | ||
| import headingStyles from '@spectrum-web-components/styles/heading.js'; |
There was a problem hiding this comment.
This is duplicative - the card styles provide the typography needed for the heading and subtitle sections.
| private get renderSubtitleAndDescription(): TemplateResult { | ||
| return html` | ||
| <div class="subtitle spectrum-Detail spectrum-Detail--sizeS"> | ||
| <div class="subtitle"> |
There was a problem hiding this comment.
this is where im seeing the issue in VRT
There was a problem hiding this comment.
@castastrophe looooks so much closer, seems like letter-spacing is the only thing off in the VRTs but I personally like the actual over the baseline. is this an acceptable difference?
There was a problem hiding this comment.
Yeah I kind of like the updated letter spacing for readability.
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
4 times, most recently
from
485f154 to
c674dcd
Compare
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
2 times, most recently
from
f84a2bf to
2103c93
Compare
caseyisonit
added
the
Status: Ready for merge
castastrophe
force-pushed
the
renovate/spectrum-css-typography-7.x
branch
from
2103c93 to
6ef7a90
Compare
This PR contains the following updates:
7.0.0-s2-foundations.17->8.1.0Release Notes
adobe/spectrum-css (@spectrum-css/typography)
v7.0.1Compare Source
Patch Changes
📝 #3522
7a47c22Thanks @castastrophe!Peer dependency for @spectrum-css/tokens updated to include v15 as well as v14.
Updated dependencies [
7a47c22]:v7.0.0Compare Source
Major Changes
📝 #3502
562396eThanks @castastrophe!Remove empty theme references to reduce complexity for components that don't need to define any mappings. This involves removing the source
themesdirectories with the emptyspectrum.cssandexpress.comfiles as well as removing the following empty or unnecessary exports:index-base.cssindex-theme.cssthemes/spectrum.cssthemes/express.cssPatch Changes
c8194b0]:v7.0.0-s2-foundations.19Compare Source
Major Changes
7fa37a7Thanks @pfulton! - Removes empty theme assets from the component; no longer publishing a themes folder or index-theme.css map.v7.0.0-s2-foundations.18Compare Source
Major Changes
#2786
f6ad55eThanks @pfulton! - feat: s2 foundations non-gray-800 colors update--spectrum-blue-800--spectrum-red-800--spectrum-orange-800--spectrum-yellow-800--spectrum-chartreuse-800--spectrum-celery-800--spectrum-green-800--spectrum-seafoam-800--spectrum-cyan-800--spectrum-indigo-800--spectrum-purple-800--spectrum-fuchsia-800--spectrum-magenta-800--spectrum-pink-800--spectrum-turqoise-800--spectrum-brown-800--spectrum-silver-800--spectrum-cinnamon-800Patch Changes
f6ad55e]:Configuration
📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.