Skip to content

fix(card): added missing sp-popover dependency #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rajdeepc merged 6 commits into from
May 12, 2025
Merged

fix(card): added missing sp-popover dependency #5449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75bab5a
fix(card): added missing popover dependency
May 7, 2025
f9dae90
chore: added changeset
May 7, 2025
53e5bcc
chore: update chromedriver to version 136.0.0
blunteshwar May 7, 2025
bc09b51
chore: update chromedriver to version 136.0.0 with updated yarn lock
blunteshwar May 7, 2025
c8d6038
chore: updated changesete message format and revert chromedriver update
May 8, 2025
da1a070
Merge branch 'main' into rajdeep/missing-popover-dependency
Rajdeepc May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-lands-work.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spectrum-web-components/card': patch
---

- **Fixed**: `sp-card` component relies on `sp-popover` for certain toggle interactive behaviors, but this dependency was missing from its dependency tree.
Copy link
Contributor

@nikkimk nikkimk May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice description.

1 change: 1 addition & 0 deletions packages/card/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"@spectrum-web-components/checkbox": "1.6.0",
"@spectrum-web-components/divider": "1.6.0",
"@spectrum-web-components/icons-workflow": "1.6.0",
"@spectrum-web-components/popover": "1.6.0",
Copy link
Contributor

@castastrophe castastrophe May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does every card require a popover? It almost seems like this should be an optional dependency? When does a card use a popover?

Copy link
Contributor Author

@Rajdeepc Rajdeepc May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a regular dependency, not an optional one. The component needs to be available when the toggles feature is used. As per my understanding optional dependencies are typically for features which can be completely replaced or deleted. We have never shipped any components with optionalDependencies

"@spectrum-web-components/shared": "1.6.0",
"@spectrum-web-components/styles": "1.6.0"
},
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7688,6 +7688,7 @@ __metadata:
"@spectrum-web-components/checkbox": "npm:1.6.0"
"@spectrum-web-components/divider": "npm:1.6.0"
"@spectrum-web-components/icons-workflow": "npm:1.6.0"
"@spectrum-web-components/popover": "npm:1.6.0"
"@spectrum-web-components/shared": "npm:1.6.0"
"@spectrum-web-components/styles": "npm:1.6.0"
languageName: unknown
Expand Down
Loading