Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
The documentation site is not reflecting the changes in the markdown. im going to check it out locally but we might need to investigate why thats not working |
The documentation system Currently:
There are several ways to tackle this but would be a good follow up fix. |
72d949e to
619e7f0
Compare
6845b64 to
f3a3947
Compare
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Reviewed all of Rajdeeps comments have been addressed and unblocking this PR while he is on PTO
f3a3947 to
8c64af6
Compare

Description
Fixed accessibility violations in the
<sp-clear-button>documentation by adding the requiredlabelattribute to all examples. The component implementation already correctly handles thelabelattribute (via theLikeAnchormixin), but the documentation examples were missing it, causing WCAG 2.1 Level A violations (4.1.2 Name, Role, Value) when rendered on the documentation site.Additionally:
ClearButtonoverridesbuttonContentand does not render slot content)ClearButton.tsto accurately document thelabelattribute instead of the non-functional slotaria-labelbehaviorMotivation and context
Users running Axe DevTools on https://swcpreviews.z13.web.core.windows.net/pr-5861/docs/components/clear-button reported "ARIA commands must have an accessible name" violations. The clear button examples were missing the
labelattribute, which is the only way to provide an accessible name since the component only renders an icon (no slot content).Related issue(s)
Author's checklist
Reviewer's checklist
Manual review test cases
Verify all clear-button examples on documentation page have accessible names
Verify clear button aria-label is set correctly
<sp-clear-button label="Clear">elementrole="button"andaria-label="Clear"on the host element