Skip to content

Conversation

@iuliauta
Copy link
Contributor

@iuliauta iuliauta commented Dec 11, 2025

Description

Update the textarea pattern regex from Docs to accept any character (including line breaks) up to 1000 times.
More details here

Motivation and context

The textarea validation should not fail for newlines even if the max character limit is not excedeed.

Related issue(s)

  • N/A

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@iuliauta iuliauta self-assigned this Dec 11, 2025
@iuliauta iuliauta requested a review from a team as a code owner December 11, 2025 12:43
@iuliauta iuliauta added Component: Textfield Status: Ready for review PR ready for review or re-review. labels Dec 11, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2025

⚠️ No Changeset found

Latest commit: 8d20657

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5932

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice easy fix! I'm approving, but we might have to look into why we have failing tests. Unfortunately, I'm having problems viewing the CircleCI failures page right now, so I can't help troubleshoot that. 🤦‍♀️

Thanks for this fix!

@rubencarvalho rubencarvalho merged commit 0ea3419 into main Dec 23, 2025
21 checks passed
@rubencarvalho rubencarvalho deleted the iuta/textarea-chars-limit-docs branch December 23, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Textfield Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants