fix(tag): update tag content color to match S2#6020
fix(tag): update tag content color to match S2#6020rubencarvalho wants to merge 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1ac3ced The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
marissahuysentruyt
left a comment
There was a problem hiding this comment.
Love a quick fix! VRTs are expected ✅
Just a quick thought- in S1, the border color and the content color of the tags match. The request was just for the content color, so I'm going to approve, but would we want to update the border color to the same neutral-content-color-* tokens as well? I believe all of the other variants and states have matching border & content colors.
Description
Corrects the tag content color in S2 Foundations by updating the system-theme-bridge token mapping from
--spectrum-neutral-subdued-content-color-*to--spectrum-neutral-content-color-*for all interaction states (default, hover, active, focus). I also updated the border-color to match the content color for consistency with the other themes.Before: Tag text rendered at gray-700 (~rgb 80,80,80) via
--spectrum-neutral-subdued-content-color-defaultAfter: Tag text renders at gray-800 (~rgb 41,41,41) via
--spectrum-neutral-content-color-defaultThe change is isolated to
1st-gen/tools/styles/tokens-v2/system-theme-bridge.css, affecting only the S2 Foundations theme.Motivation and context
It was reported via Slack that the tag content color in S2 Foundations does not match the S2 design spec. The "subdued" variant produces a noticeably lighter text color than intended, reducing contrast and deviating from the Figma token specs.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify tag content color matches S2 spec in default state
--spectrum-neutral-content-color-default