fix(combobox): align slotted field label with standalone label#6047
Open
aramos-adobe wants to merge 2 commits intonikkimk/form-field-mixinfrom
Open
fix(combobox): align slotted field label with standalone label#6047aramos-adobe wants to merge 2 commits intonikkimk/form-field-mixinfrom
aramos-adobe wants to merge 2 commits intonikkimk/form-field-mixinfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the combobox slotted field label with standalone (typography, colors, sizes) and fixes picker button placement and disabled high-contrast styling.
This is also aims to align grid layout of the combobox referenced in SWC-1316
Motivation and context
The combobox uses FieldLabelMixin, which renders the label in shadow DOM. The slotted label’s CSS did not match the standalone
<sp-field-label>component, and the picker button could misalign when a label was present. Disabled state in forced-colors also needed to useGrayTextfor the picker button.Related issue(s)
Screenshots (if appropriate)
Still left TO-DO
.spectrum-PickerButton--quietdisabled stateAuthor's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Slotted label vs standalone: Combobox default story and "With standalone field label" story — slotted label (e.g.
<span slot="field-label">) matches standalone<sp-field-label>in typography, spacing, and colors.Picker button alignment: Combobox with a slotted label — picker button stays aligned with the input row.
Forced-colors disabled: Disabled combobox in high-contrast mode — label and picker button use GrayText.
forced-colors: active" or Windows High Contrast).No regressions: Existing combobox stories (sizes, quiet, invalid, readonly, etc.) still look and behave correctly.
Device review