Skip to content

Conversation

@ThisIsMissEm
Copy link

@ThisIsMissEm ThisIsMissEm commented Jan 21, 2026

πŸ”— Linked issue

I didn't create an issue first, but this was a feature added in Vine.js back in June 2024.

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Sometimes when validating requests, you just want to attempt to validate the request, but then handle the errors yourself, instead of having them propagate upwards out of your controller.

This adds support for validator.tryValidate from Vine.js to the HttpRequest as tryValidateUsing.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This will require a documentation change, if we agree this is a good feature to have.

Copy link
Member

@thetutlage thetutlage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a small change

Copy link
Author

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for using class private methods, instead of typescript private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants