-
-
Notifications
You must be signed in to change notification settings - Fork 660
feat: add tryValidateUsing to HttpRequest #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ThisIsMissEm
wants to merge
2
commits into
adonisjs:7.x
Choose a base branch
from
ThisIsMissEm:feat/request-try-validate-using
base: 7.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add tryValidateUsing to HttpRequest #5034
ThisIsMissEm
wants to merge
2
commits into
adonisjs:7.x
from
ThisIsMissEm:feat/request-try-validate-using
+219
β21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
commented
Jan 21, 2026
thetutlage
reviewed
Jan 23, 2026
thetutlage
requested changes
Jan 23, 2026
Member
thetutlage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a small change
ThisIsMissEm
commented
Jan 23, 2026
Author
ThisIsMissEm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for using class private methods, instead of typescript private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
I didn't create an issue first, but this was a feature added in Vine.js back in June 2024.
β Type of change
π Description
Sometimes when validating requests, you just want to attempt to validate the request, but then handle the errors yourself, instead of having them propagate upwards out of your controller.
This adds support for
validator.tryValidatefrom Vine.js to theHttpRequestastryValidateUsing.π Checklist
This will require a documentation change, if we agree this is a good feature to have.