feat(i18n): add command to publish localization templates#5037
Merged
thetutlage merged 6 commits intoadonisjs:6.xfrom Feb 4, 2026
Merged
feat(i18n): add command to publish localization templates#5037thetutlage merged 6 commits intoadonisjs:6.xfrom
thetutlage merged 6 commits intoadonisjs:6.xfrom
Conversation
Member
|
Hello. Thanks for creating the PR. Let's add a couple of tests for this too. Also, we should not overwrite the existing |
thetutlage
requested changes
Jan 28, 2026
thetutlage
requested changes
Feb 1, 2026
Member
thetutlage
left a comment
There was a problem hiding this comment.
Thanks for the PR. However, we will need proper tests!
…sts for lang publish command
…lang publish tests
… behavior in lang publish tests
Author
|
@thetutlage updated |
Member
|
Looks good. Let's get it in. In future, I might open up possibilities for multiple packages to register their default translations and allow this command to publish them in one-go. But, doesn't need to happen today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
#5035
Inspired by Laravel's
php artisan lang:publishcommand. Eject translation template of built-in validation messages to/resources/lang/en/validator.json.Not sure if this command should be included in core or i18n.
📝 Checklist