Skip to content

Extend object instead for item types #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobbieTheWagner merged 1 commit into from
Sep 20, 2025
Merged

Extend object instead for item types #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions addon/components/drag-sort-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function getComputedStyleInt(element: HTMLElement, cssProp: string) {
return parseInt(valueStr, 10);
}

interface DragSortItemSignature<Item extends Record<string, unknown>> {
interface DragSortItemSignature<Item extends object> {
Args: {
additionalArgs: object;
determineForeignPositionAction: unknown;
Expand All @@ -35,9 +35,9 @@ interface DragSortItemSignature<Item extends Record<string, unknown>> {
};
}

export default class DragSortItem<
Item extends Record<string, unknown>,
> extends Component<DragSortItemSignature<Item>> {
export default class DragSortItem<Item extends object> extends Component<
DragSortItemSignature<Item>
> {
@service declare dragSort: DragSort<Item>;

declare el: HTMLElement;
Expand Down
8 changes: 4 additions & 4 deletions addon/components/drag-sort-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { service } from '@ember/service';
import { A } from '@ember/array';
import type DragSort from 'ember-drag-sort/services/drag-sort';

interface DragSortListSignature<Item extends Record<string, unknown>> {
interface DragSortListSignature<Item extends object> {
Element: HTMLDivElement;
Args: {
additionalArgs: object;
Expand All @@ -28,9 +28,9 @@ interface DragSortListSignature<Item extends Record<string, unknown>> {
};
}

export default class DragSortList<
Item extends Record<string, unknown>,
> extends Component<DragSortListSignature<Item>> {
export default class DragSortList<Item extends object> extends Component<
DragSortListSignature<Item>
> {
@service declare dragSort: DragSort<Item>;

declare el: HTMLElement;
Expand Down
4 changes: 1 addition & 3 deletions addon/services/drag-sort.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import { next } from '@ember/runloop';
import { tracked } from '@glimmer/tracking';
import { setProperties } from '@ember/object';

export default class DragSort<
Item extends Record<string, unknown>,
> extends Service {
export default class DragSort<Item extends object> extends Service {
#eventTarget = new EventTarget();

on(eventName: string, callback: (event: CustomEvent) => void) {
Expand Down