Skip to content

Conversation

@mkszepp
Copy link
Contributor

@mkszepp mkszepp commented May 10, 2025

@glimmer/tracking removed because it's a real package, but one we don't want to use. This comes up in embroider/vite where the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want.

ref ember-cli/ember-addon-blueprint#35

In additional we can remove safely also dependency ember-auto-import... its not necessary for v2 addon

@SergeAstapov
Copy link
Contributor

@mkszepp could you please update pnpm-lock.yaml file as CI fails with error

ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with <ROOT>/ember-file-upload/package.json

@SergeAstapov SergeAstapov self-requested a review May 11, 2025 02:26
@mkszepp
Copy link
Contributor Author

mkszepp commented May 11, 2025

@SergeAstapov now ci is green

@SergeAstapov
Copy link
Contributor

Thank you @mkszepp !

@SergeAstapov SergeAstapov merged commit dd2941f into adopted-ember-addons:master May 11, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request May 11, 2025
@mkszepp mkszepp deleted the remove-unneeded-peer branch May 11, 2025 13:39
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants