Updating documentation for modifier #375
Conversation
cah-brian-gantzler
left a comment
cah-brian-gantzler
left a comment
There was a problem hiding this comment.
It looks like you were attempting to remove the references to the component version, under the heading about the group model, the code is showing the component version. Im not sure how to attach a comment to code you didnt change, so there may be other references
| ### modifier | ||
| ```hbs | ||
| {{! app/templates/my-route.hbs }} | ||
|
|
||
| <ol {{sortable-group onChange=(action "reorderItems")}}> | ||
| {{#each model.items as |modelItem|}} | ||
| <li {{sortable-item model=modelItem}}> | ||
| {{modelItem.name}} | ||
| <span class="handle" {{sortable-handle}}>↕</span> | ||
| </li> | ||
| {{/each}} | ||
| </ol> | ||
| ``` |
There was a problem hiding this comment.
If the modifier version is going to be released as 3.x.x, probably we probably should remove references to in the V2 migration guide since I dont think it was ever released in a 2.x series
| The modifier version does not support `groupModel`, use the currying of `action` or the `fn` helper. | ||
|
|
||
| ```hbs | ||
| {{! app/templates/my-route.hbs }} | ||
|
|
||
| <ol {{sortable-group onChange=(action "reorderItems" model)}}> | ||
| {{#each model.items as |modelItem|}} | ||
| <li {{sortable-item model=modelItem}}> | ||
| {{modelItem.name}} | ||
| <span class="handle" {{sortable-handle}}>↕</span> | ||
| </li> | ||
| {{/each}} | ||
| </ol> | ||
| ``` |
There was a problem hiding this comment.
Same of the references to modifier
| modifier | ||
| ```hbs | ||
| <ol {{sortable-group direction="x" onChange=(action "reorderItems")}> | ||
| ``` |
There was a problem hiding this comment.
remove modifier references
| modifier | ||
| ```hbs | ||
| <li {{sortable-item spacing=15}}> | ||
| ``` |
There was a problem hiding this comment.
remove modifier refeerences
| modifier | ||
| ```hbs | ||
| <li {{sortable-item distance=30}}> | ||
| ``` |
There was a problem hiding this comment.
remove modifier references
| modifier | ||
| ```hbs | ||
| <li {{#sortable-item | ||
| onDragStart=(action "dragStarted") | ||
| onDragStop=(action "dragStopped") | ||
| model=modelItem | ||
| }} | ||
| > | ||
| {{modelItem.name}} | ||
| <span class="handle" {{sortable-handle}}>↕</span> | ||
| </li> | ||
| ``` |
There was a problem hiding this comment.
modifier references
|
@ygongdev any plans to circle back and address the feedback or is it ok to close? |
3 participants
No description provided.