-
-
Notifications
You must be signed in to change notification settings - Fork 46
Shows Binary reproducibility by thirdparty icon on the adoptium.net #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Shows Binary reproducibility by thirdparty icon on the adoptium.net #643
Conversation
✅ Deploy Preview for adoptium-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 76.26% 76.58% +0.32%
==========================================
Files 175 176 +1
Lines 3295 3353 +58
Branches 1028 1045 +17
==========================================
+ Hits 2513 2568 +55
- Misses 664 667 +3
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@andrew-m-leonard @smlambert Can you take a look at the PR and leave your suggestions about Marketplace page please. |
|
Hi Sehrish, can you try with the 3rd image listed in #554 (comment) as it has a lighter edge which will show up better. I can create a few other options with more contrast also. |
|
@smlambert How does this look like? If you want to try something with more contrast we will give it a try too. |
That is improved, but I will share a couple of other revisions with you shortly. thanks! |
Description of change
This PR introduces build attestation support for Temurin binaries and surfaces a reproducibility indicator in the Release Results UI when a third party attestation is available. Closes #554
useAttestationshookuseAttestationsprovides a cached, checksum based view of build attestations for a given release.release_nameendpoint and joins them to binaries viachecksum, without modifying existing release or binary data structures.target_checksum, enabling O(1) attestation checks during rendering.useRefso that:- previously resolved checksums are not refetched on rerender
- cache updates do not trigger unnecessary component rerenders
undefined404response is treated as “no attestations available” and cached accordinglyerrorstateattestations,isLoading,error) suitable for reuse across multiple views (e.g. Releases, Marketplace).UI reference
I’ve attached a screenshot showing how the reproducibility indicator appears alongside existing certification icons on the Latest Release page. The icon shows a tooltip as well, however icon design can be improved. Suggestions required.
Open question
This PR currently surfaces the attestation indicator on the Latest Releases page only.
I appreciate your guidance on how you’d like the reproducibility indicator to appear in the UI on the Marketplace page (e.g. placement alongside existing badges, visibility rules, or any differences from the Release Results view).
Added unit tests for the
useAttestationshook as well; all tests pass locally.Checklist
npm testandnpm run buildpasses