Skip to content

Add GitCompare workflow and CommitHunter script for build comparison#1051

Merged
LongyuZhang merged 1 commit intoadoptium:masterfrom
ShantKhatri:ch-workflow-issue-1043
Jul 2, 2025
Merged

Add GitCompare workflow and CommitHunter script for build comparison#1051
LongyuZhang merged 1 commit intoadoptium:masterfrom
ShantKhatri:ch-workflow-issue-1043

Conversation

@ShantKhatri
Copy link
Contributor

@ShantKhatri ShantKhatri commented Jun 18, 2025 •
edited
Loading

Fixes #1043
The implemented workflow lists repo SHA compare.

To trigger the GitCompare action, comment the good and bad build java -version, which should be in the format of:
.ch_gitcompare --good_build <good_build> --bad_build <bad_build>

@netlify
Copy link

netlify bot commented Jun 18, 2025 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium-trss canceled.

Name Link
🔨 Latest commit 3ea5d9e
🔍 Latest deploy log https://app.netlify.com/projects/eclipsefdn-adoptium-trss/deploys/68547d44717bf200080230c8

@ShantKhatri
Copy link
Contributor Author

ShantKhatri commented Jun 18, 2025

/gitcompare
openjdk version "21.0.7-beta" 2025-04-15
IBM Semeru Runtime Open Edition 21.0.7+6-202504292333 (build 21.0.7-beta+6-202504292333)
Eclipse OpenJ9 VM 21.0.7+6-202504292333 (build master-ab9584ee40, JRE 21 Linux s390x-64-Bit Compressed References 20250429_435 (JIT enabled, AOT enabled)
OpenJ9 - ab9584ee40
OMR - 38fbca611
JCL - 39c20bca9 based on jdk-21.0.7+6

openjdk version "21.0.8-beta" 2025-07-15
IBM Semeru Runtime Open Edition 21.0.8+2-202505132342 (build 21.0.8-beta+2-202505132342)
Eclipse OpenJ9 VM 21.0.8+2-202505132342 (build master-4d92969242, JRE 21 Linux s390x-64-Bit Compressed References 20250513_448 (JIT enabled, AOT enabled)
OpenJ9 - 4d92969242
OMR - b4802c56c
JCL - 2119fbf3f based on jdk-21.0.8+2

@ShantKhatri ShantKhatri marked this pull request as draft June 18, 2025 10:07
@ShantKhatri ShantKhatri force-pushed the ch-workflow-issue-1043 branch from 514b79a to ab04335 Compare June 18, 2025 10:34
@ShantKhatri
Copy link
Contributor Author

ShantKhatri commented Jun 18, 2025

/gitcompare
openjdk version "21.0.7-beta" 2025-04-15
IBM Semeru Runtime Open Edition 21.0.7+6-202504292333 (build 21.0.7-beta+6-202504292333)
Eclipse OpenJ9 VM 21.0.7+6-202504292333 (build master-ab9584ee40, JRE 21 Linux s390x-64-Bit Compressed References 20250429_435 (JIT enabled, AOT enabled)
OpenJ9 - ab9584ee40
OMR - 38fbca611
JCL - 39c20bca9 based on jdk-21.0.7+6

openjdk version "21.0.8-beta" 2025-07-15
IBM Semeru Runtime Open Edition 21.0.8+2-202505132342 (build 21.0.8-beta+2-202505132342)
Eclipse OpenJ9 VM 21.0.8+2-202505132342 (build master-4d92969242, JRE 21 Linux s390x-64-Bit Compressed References 20250513_448 (JIT enabled, AOT enabled)
OpenJ9 - 4d92969242
OMR - b4802c56c
JCL - 2119fbf3f based on jdk-21.0.8+2

@ShantKhatri ShantKhatri force-pushed the ch-workflow-issue-1043 branch from 51adeb6 to c55b6aa Compare June 18, 2025 12:23
@ShantKhatri ShantKhatri marked this pull request as ready for review June 18, 2025 12:43
@ShantKhatri
Copy link
Contributor Author

ShantKhatri commented Jun 18, 2025

Here is sample command:
.ch_gitcompare --good_build "openjdk version "21.0.7-beta" 2025-04-15 IBM Semeru Runtime Open Edition 21.0.7+6-202504292333 (build 21.0.7-beta+6-202504292333) Eclipse OpenJ9 VM 21.0.7+6-202504292333 (build master-ab9584ee40, JRE 21 Linux s390x-64-Bit Compressed References 20250429_435 (JIT enabled, AOT enabled) OpenJ9 - ab9584ee40 OMR - 38fbca611 JCL - 39c20bca9 based on jdk-21.0.7+6)" --bad_build "openjdk version "21.0.8-beta" 2025-07-15 IBM Semeru Runtime Open Edition 21.0.8+2-202505132342 (build 21.0.8-beta+2-202505132342) Eclipse OpenJ9 VM 21.0.8+2-202505132342 (build master-4d92969242, JRE 21 Linux s390x-64-Bit Compressed References 20250513_448 (JIT enabled, AOT enabled) OpenJ9 - 4d92969242 OMR - b4802c56c JCL - 2119fbf3f based on jdk-21.0.8+2)"

@llxia
Copy link
Contributor

llxia commented Jun 18, 2025

Thanks @ShantKhatri . In the description, we have both Fixes https://github.com/adoptium/aqa-test-tools/issues/1043 and related to: https://github.com/adoptium/aqa-test-tools/issues/1043. Please use one. Using git keyword Fixes will close the issue once the PR is merged. For details, please see https://github.com/adoptium/aqa-tests/blob/master/Contributing.md#submitting-a-contribution-to-aqavit

@ShantKhatri ShantKhatri force-pushed the ch-workflow-issue-1043 branch from 81c0b72 to 862a020 Compare June 19, 2025 02:46
@ShantKhatri
Copy link
Contributor Author

ShantKhatri commented Jun 19, 2025

Thanks @ShantKhatri . In the description, we have both Fixes https://github.com/adoptium/aqa-test-tools/issues/1043 and related to: https://github.com/adoptium/aqa-test-tools/issues/1043. Please use one. Using git keyword Fixes will close the issue once the PR is merged. For details, please see https://github.com/adoptium/aqa-tests/blob/master/Contributing.md#submitting-a-contribution-to-aqavit

Thanks @llxia . I have updated the PR description and have squashed all commits into one by changing the commit message according to Adoptium's contributor guide.

@ShantKhatri ShantKhatri marked this pull request as draft June 19, 2025 20:38
@ShantKhatri
Add GitCompare workflow and CommitHunter script for build comparison
3ea5d9e 
This implementation have added workflow which is for to run the github action and have script file which is to parse the java -version out of the comment in the pull request.

Fixes: adoptium#1043
Signed-off-by: Prashantkumar Khatri <khatri2105104@st.jmi.ac.in>

Moved commit_hunter.sh from .github to root folder

Enhance GitCompare workflow: add error handling, improve output logging, and ensure permissions for pull requests

Update GitCompare command parsing: change command prefix to '.ch_gitcompare' and improve error messages for invalid formats

Moved parse-comment Logic from yml file to shell script

Fixes: adoptium#1043
Signed-off-by: Prashantkumar Khatri <khatri2105104@st.jmi.ac.in>

Revert "Moved parse-comment Logic from yml file to shell script"

This reverts commit c156891.
@ShantKhatri ShantKhatri force-pushed the ch-workflow-issue-1043 branch from 193f747 to 3ea5d9e Compare June 19, 2025 21:12
@ShantKhatri ShantKhatri marked this pull request as ready for review June 19, 2025 21:12
@llxia
Copy link
Contributor

llxia commented Jun 20, 2025

@RashmiLnu, if you worked on this PR, please add yourself as a co-author. Thanks https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@llxia llxia mentioned this pull request Jun 27, 2025
Closed
LongyuZhang
LongyuZhang approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit e4da439 into adoptium:master Jul 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CommitHunter: create Github workflow to list repo sha compare

3 participants

@ShantKhatri @llxia @LongyuZhang