Merged
Conversation
Dacapo.jsx matches new datastructure: 1. Since jdkDate is null, derive it from t.timestamp. 2. Extract metric with respect to test.duration and test.benchmarkName instead of tests.testData.metrics Notes for possible related issues: -Can optimize the code, currently I believe there are wasteful null values in resultsByJDKBuild due to change 2. -Current code assumes only one iteration per benchmark, but there could be multiple iterations. Fixes: adoptium#1049 Signed-off-by: Matthew Wei <mwei2@andrew.cmu.edu>
✅ Deploy Preview for eclipsefdn-adoptium-trss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
karianna
approved these changes
Jul 2, 2025
test-result-summary-client/src/Dashboard/Widgets/Graph/Dacapo.jsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dacapo.jsx matches new datastructure:
Notes for possible related issues:
-Can optimize the code, currently I believe there are wasteful null values in resultsByJDKBuild due to change 2.
-Current code assumes only one iteration per benchmark, but there could be multiple iterations.
Fixes: #1049
TRSS local result:
