Skip to content

Fix Perf top page empty build issue #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smlambert merged 1 commit into from
Jul 11, 2025
Merged

Fix Perf top page empty build issue #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 2 additions & 56 deletions test-result-summary-client/src/Build/TopLevelBuildTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function TopLevelBuildTable(props) {

if (buildInfo) {
// Define a function that renders a table cell for a 'FvTestBuild' object.
const renderFvTestBuild = (value) => {
const renderTestBuild = (value) => {
// If the provided 'value' argument is truthy and has a 'buildNum' property:
if (value && value.buildNum) {
// Call the 'setBuildsStatus' function to update the 'buildResult' property of the 'value' object.
Expand All @@ -130,60 +130,6 @@ function TopLevelBuildTable(props) {
return null;
};

// Define function to render build link
const renderBuild = (value) => {
// If value exists and has a buildNum property
if (value && value.buildNum) {
// Set the result variable to the build result
let result = value.buildResult;
// If the value has tests and the length of the tests array is greater than 0
if (value.tests && value.tests.length > 0) {
// Set the result variable to the test result of the first test in the tests array
result = value.tests[0].testResult;
// If the first test has an _id property
if (value.tests[0]._id) {
// Return a link to the output test page for the first test
return (
<div>
<Link
to={{
pathname: '/output/test',
search: params({
id: value.tests[0]._id,
}),
}}
style={{
color:
result === 'PASSED'
? '#2cbe4e'
: result === 'FAILED'
? '#f50'
: '#DAA520',
}}
>
Build #{value.buildNum}
</Link>
</div>
);
}
} else {
// Return a JSX element with a 'BuildStatus' and 'renderPublishName' component, passing in relevant props.
return (
<div>
<BuildStatus
status={value.buildResult}
id={value._id}
buildNum={value.buildNum}
/>
{renderPublishName(value)}
</div>
);
}
}
// If value does not exist or does not have a buildNum property, return null
return null;
};

// Define function to render Jenkins links
const renderJenkinsLinks = ({ buildName, buildNum, buildUrl, url }) => {
// Temporarily support BlueOcean link under folders
Expand Down Expand Up @@ -330,7 +276,7 @@ function TopLevelBuildTable(props) {
title: 'Build',
dataIndex: 'build',
key: 'build',
render: type === 'Perf' ? renderBuild : renderFvTestBuild,
render: renderTestBuild,
sorter: (a, b) => {
return a.key.localeCompare(b.key);
},
Expand Down
Loading