Enable ValueClassTest #6771
Merged
Enable ValueClassTest #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@theresa-m, could you please review. |
theresa-m
reviewed
Dec 4, 2025
Contributor
theresa-m
left a comment
theresa-m
left a comment
There was a problem hiding this comment.
Since there are no automated runs for these tests yet can you run a grinder to confirm they are passing? Similar to https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/56700/
| compiler/valhalla/inlinetypes/TestVirtualThreads.java#xcomp-co-test-di https://github.com/eclipse-openj9/openj9/issues/13182 generic-all | ||
| compiler/valhalla/inlinetypes/TestVirtualThreads.java#xcomp-co-test-di-exclude-helper https://github.com/eclipse-openj9/openj9/issues/13182 generic-all | ||
| compiler/valhalla/inlinetypes/TestVirtualThreads.java#xcomp-co-test-di-helper https://github.com/eclipse-openj9/openj9/issues/13182 generic-all | ||
| compiler/valhalla/inlinetypes/bootstrap/TestBootClassloader.java https://github.com/eclipse-openj9/openj9/issues/13182 generic-all |
Contributor
There was a problem hiding this comment.
Please remove the changes in this line.
Contributor
There was a problem hiding this comment.
@AditiS11 - once you address @theresa-m 's review comment, we will be good to merge
Contributor
Author
There was a problem hiding this comment.
I don't see any difference between the two lines. Not sure why it appears like that.
AditiS11
force-pushed
the
ValueClassTest
branch
2 times, most recently
from
542b570 to
e39c76d
Compare
JasonFengJ9
approved these changes
Dec 5, 2025
AditiS11
force-pushed
the
ValueClassTest
branch
from
45641aa to
e39c76d
Compare
Contributor
Author
AditiS11
force-pushed
the
ValueClassTest
branch
from
e39c76d to
5dce08c
Compare
AditiS11
force-pushed
the
ValueClassTest
branch
from
5dce08c to
e22c642
Compare
theresa-m
approved these changes
Dec 10, 2025
smlambert
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by: eclipse-openj9/openj9#23008