Open
Conversation
Contributor
Author
|
Mmm... maybe |
Contributor
Author
Nope. Different things. |
karianna
approved these changes
Mar 18, 2026
sophia-guo
reviewed
Mar 19, 2026
| generatedJti.setProperty("jck.env.compiler.refExecute.fileSep", "/"); | ||
| generatedJti.setProperty("jck.env.compiler.refExecute.pathSep", ":"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
You could create a variable to hold the correct value for "refExecute" or "compRefExecute" and use this variable in all the places to avoid duplicating all the code.
Contributor
Author
There was a problem hiding this comment.
Hi @sophia-guo ,
Yes, let's do that later on, though. We're on a hurry to have JCK26 compliance testing done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like JCK26 requires these new variables:
jck.env.runtime.refExecute.cmdAsString- required by some runtime tests inspecial.jck.jck.env.compiler.refExecute.cmdAsString- required by some compiler tests insanity.jck, also required inextended.jck.Don't know how to test this, maybe we should test somehow before merging?