-
-
Notifications
You must be signed in to change notification settings - Fork 101
unixPB: adds roles xcode_offline and brew to Unix_Playbook #3417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mahdipub linter failures. |
Seems all resolved now. |
|
@mahdipub Ansible linter fixes needed by the looks. |
Lint removed. Could you please try again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
5d627af to
d6921dd
Compare
The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.
d6921dd to
985251d
Compare
karianna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure we already have scripts that install brew.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/xcode_offline.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
71d9c8d to
aee9b91
Compare
karianna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/files/.place_holder
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
0b610c7 to
f6f2995
Compare
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
17fb05b to
7ea80ae
Compare
|
I might be missing something but the current roles already support this. infrastructure/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode15/tasks/main.yml Lines 25 to 28 in 137a3f3
checks for the |
This PR, meant to support wider range of xcode version and architecture. If we decided to merge this PR, it might be better to remove the one you mentioned. |
sxa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have quite a few roles that are sourcing third party things from a directory called /Vendor_Files if it exists (A similar example being this for the XLC compiler on AIX) - would it be possible to do the same for this situation instead of requiring it to be a directory inside the checked out git tree?
This way of operations means we can support the /Vendor_Files directory being stored on the ansible tower/AWX server that is used to deploy to our machines.
ae50e6f to
691d005
Compare
691d005 to
2fe953a
Compare
@sxa that is done. |
|
/thaw |
Pull Request unblocked - code freeze is over.
The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.
Checklist