Skip to content

Remove Liberica install as we don't directly connect jenkins to Solaris now#4156

Merged
sxa merged 3 commits intoadoptium:masterfrom
sxa:remove_liberica
Dec 5, 2025
Merged

Remove Liberica install as we don't directly connect jenkins to Solaris now#4156
sxa merged 3 commits intoadoptium:masterfrom
sxa:remove_liberica

Conversation

@sxa
Copy link
Member

@sxa sxa commented Nov 25, 2025

Leaving it commented out for reference in case someone really wants to connect an insecure jenkins to their solaris box.

This is currently preventing VPC from running cleanly due to a certificate error:

06:41:42 TASK [Common : Download Liberica 11.0.18+10 (x64)] *****************************
06:41:42 fatal: [127.0.0.1]: FAILED! => {"changed": false, "dest": "/tmp/bellsoft-jdk11.0.18+10-solaris.tar.gz", "elapsed": 0, "msg": "Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)>", "url": "https://download.bell-sw.com/java/11.0.18+10/bellsoft-jdk11.0.18+10-solaris-x64.tar.gz"}
06:41:42 
Checklist

@sxa sxa changed the title Remove Liberica install as we don't direclty connect jenkins to Solaris now Remove Liberica install as we don't directly connect jenkins to Solaris now Nov 25, 2025
…is now

Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just delete the outdated code, we can look at git history

@sxa
Copy link
Member Author

sxa commented Nov 26, 2025

I think just delete the outdated code, we can look at git history

I would normally agree but in this case since it's an unusual setup that others utilise I'm more inclined to leave it in and commented out to aid discovery instead of having to know it's there and search back through history.

I suppose as an alternative it could be removed and replaced with a comment saying something like "We used to install Liberica with a custom patch for Solaris 10 as per #2947" which would also make it clear.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa sxa requested a review from karianna December 1, 2025 10:47
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sxa sxa merged commit d713ec0 into adoptium:master Dec 5, 2025
11 of 13 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2025 Adoptium Plan Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants