Remove Liberica install as we don't directly connect jenkins to Solaris now#4156
Merged
sxa merged 3 commits intoadoptium:masterfrom Dec 5, 2025
Merged
Remove Liberica install as we don't directly connect jenkins to Solaris now#4156sxa merged 3 commits intoadoptium:masterfrom
sxa merged 3 commits intoadoptium:masterfrom
Conversation
…is now Signed-off-by: Stewart X Addison <sxa@ibm.com>
karianna
requested changes
Nov 26, 2025
Contributor
karianna
left a comment
There was a problem hiding this comment.
I think just delete the outdated code, we can look at git history
Member
Author
I would normally agree but in this case since it's an unusual setup that others utilise I'm more inclined to leave it in and commented out to aid discovery instead of having to know it's there and search back through history. I suppose as an alternative it could be removed and replaced with a comment saying something like "We used to install Liberica with a custom patch for Solaris 10 as per #2947" which would also make it clear. |
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Signed-off-by: Stewart X Addison <sxa@ibm.com>
karianna
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving it commented out for reference in case someone really wants to connect an insecure jenkins to their solaris box.
This is currently preventing VPC from running cleanly due to a certificate error:
Checklist