Modernize demo dependencies and runtime cleanup#5
Open
adrianmilne wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pom.xml.TemperatureEventimmutable with defensive copies and adjusting logging severities for alert types.Description
pom.xmlto targetJava 11, bump Spring to5.3.34, add JUnit 5 and modern Maven plugins andmaven-surefire-pluginto enable tests and modern compilation behavior.StartDemoto validate arguments (parseNumberOfEvents), use try-with-resources forClassPathXmlApplicationContext, and wait for the generatorFutureto complete.RandomTemperatureEventGeneratorto return aFuture<?>, useThreadLocalRandom, handle interruptions properly, and shut down the single-thread executor when finished.TemperatureEventby making itfinal, usingfinalfields, performing defensive copies ofDatevalues, and addingequals/hashCode.DisposableBeaninTemperatureEventHandlerand destroying createdEPStatements and theEPServiceProviderindestroy().LOG.error, warnings useLOG.warn, and monitor output usesLOG.info.src/test/java/com/cor/cep/event/TemperatureEventTest.javathat verifies defensive copying of the timestamp.Testing
mvn testin the environment but the build failed due to inability to download a Maven plugin from Maven Central (HTTP 403), so tests could not be executed here; the new JUnit 5 test file was added but not run successfully under the constrained environment.Codex Task