chore: adding suppoprt for ignoreSessionCookies configuration option

Author: jarrodek

app.js

@@ -98,6 +98,7 @@ class ArcInit {
     ipc.on('popup-app-menu-opened', this._popupMenuOpened.bind(this));
     ipc.on('popup-app-menu-closed', this._popupMenuClosed.bind(this));
     ipc.on('system-theme-changed', this._systemThemeChangeHandler.bind(this));
+    document.body.addEventListener('settings-changed', this._settingsHandler.bind(this));
   }
   /**
    * Requests initial state information from the main process for current
@@ -134,7 +135,9 @@ class ArcInit {
       this.reportFatalError(e);
       throw e;
     }
-
+    if (typeof cnf.ignoreSessionCookies === 'boolean') {
+      this.cookieBridge.ignoreSessionCookies = cnf.ignoreSessionCookies;
+    }
     await this.initApp(cnf);
     await this.upgradeApp(cnf);
     await this.processInitialPath();
@@ -532,6 +535,21 @@ class ArcInit {
       console.error(e);
     }
   }
+
+  /**
+   * A handler for settings change event.
+   * Performs actions that are important when a confic object has changed.
+   *
+   * @param {CustomEvent} e An event dispatched by preferences proxy.
+   */
+  _settingsHandler(e) {
+    const { name, value } = e.detail;
+    switch (name) {
+      case 'ignoreSessionCookies':
+        this.cookieBridge.ignoreSessionCookies = value;
+        break;
+    }
+  }
 }
 
 const initScript = new ArcInit();

package.json

@@ -83,7 +83,7 @@
     "@advanced-rest-client/electron-drive": "^0.4.0",
     "@advanced-rest-client/electron-oauth2": "^2.1.2",
     "@advanced-rest-client/electron-request": "^2.2.4",
-    "@advanced-rest-client/electron-session-state": "^2.0.0",
+    "@advanced-rest-client/electron-session-state": "^2.1.0",
     "amf-client-js": "^4.0.3",
     "camelcase": "^5.3.1",
     "codemirror": "^5.50.0",

test/session-cookies/basic.app.spec.js

@@ -0,0 +1,58 @@
+const { assert } = require('chai');
+const fs = require('fs-extra');
+const path = require('path');
+const bootstrap = require('../test-bootstrap.js');
+
+describe('Session cookies', function() {
+  let app;
+  before(async () => {
+    await fs.outputJson(bootstrap.settingsFilePath, {
+      ignoreSessionCookies: true
+    });
+    app = await bootstrap.runAppDeffered(2000);
+  });
+
+  after(async () => {
+    if (app && app.isRunning()) {
+      await app.stop();
+    }
+    const basePath = path.join('test', 'playground');
+    await fs.remove(basePath);
+  });
+
+  it('sets ignoreSessionCookies on CookieBridge when init', async () => {
+    const result = await app.client.execute(async () => {
+      /* global initScript */
+      return initScript.cookieBridge.ignoreSessionCookies;
+    });
+    assert.isTrue(result.value);
+  });
+
+  it('updates ignoreSessionCookies on CookieBridge instance', async () => {
+    const result = await app.client.execute(async () => {
+      document.body.dispatchEvent(new CustomEvent('settings-changed', {
+        bubbles: true,
+        detail: {
+          name: 'ignoreSessionCookies',
+          value: false,
+        }
+      }));
+      return initScript.cookieBridge.ignoreSessionCookies;
+    });
+    assert.isFalse(result.value);
+  });
+
+  it('ignores other setting change events', async () => {
+    const result = await app.client.execute(async () => {
+      document.body.dispatchEvent(new CustomEvent('settings-changed', {
+        bubbles: true,
+        detail: {
+          name: 'a',
+          value: 'b',
+        }
+      }));
+      return initScript.cookieBridge.ignoreSessionCookies;
+    });
+    assert.isFalse(result.value);
+  });
+});