Skip to content

Conversation

@GeekMasher
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 13, 2025 15:50
@github-actions
Copy link

github-actions bot commented Jun 13, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f881ee7.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds flexible handling for the CodeQL working directory by introducing a helper to locate or create it, and updates main.rs to use this helper.

  • Introduce Action::get_codeql_dir to pick/create a CodeQL base directory in either .codeql or the runner temp area.
  • Update main.rs to call get_codeql_dir and derive databases and sarif_output paths from it.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/action.rs Added get_codeql_dir to locate or create the CodeQL directory
src/main.rs Replaced hard-coded .codeql joins with calls to get_codeql_dir
Comments suppressed due to low confidence (2)

src/action.rs:139

  • No tests cover get_codeql_dir; consider adding unit tests for both the primary .codeql path and the fallback temp path, including failure scenarios.
pub fn get_codeql_dir(&self) -> Result<PathBuf> {

src/main.rs:28

  • [nitpick] The variable name databases holds a directory path. Consider renaming it to databases_dir to clarify its purpose.
let databases = codeql_dir.join("databases");

@GeekMasher GeekMasher enabled auto-merge June 13, 2025 15:59
@GeekMasher GeekMasher disabled auto-merge June 13, 2025 16:03
@GeekMasher GeekMasher merged commit edec647 into main Jun 13, 2025
10 checks passed
@GeekMasher GeekMasher deleted the codeql-paths branch June 13, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants