Skip to content

Conversation

@GeekMasher
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 18, 2025 15:25
@GeekMasher GeekMasher enabled auto-merge June 18, 2025 15:25
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a6b3d93.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails
cargo/ghastoolkit 0.11.4 UnknownUnknown
cargo/serde_json >= 1.0.0, < 2.0.0 🟢 6
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review⚠️ 0Found 2/23 approved changesets -- score normalized to 0
Maintained🟢 52 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 5
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Fuzzing🟢 10project is fuzzed
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • Cargo.lock
  • Cargo.toml

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors how SARIF files are loaded and parsed by replacing manual file reads with a Sarif::try_from call, adds error logging for parse failures, logs the SARIF output path, and updates the serde_json dependency version.

  • Use Sarif::try_from for parsing and add an Err branch for error logging
  • Log the SARIF output path after processing
  • Change serde_json dependency from a fixed version to a caret requirement

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main.rs Refactored SARIF parsing to use Sarif::try_from, added error handling and output-path logging
Cargo.toml Updated serde_json version specification to "1.0"

@GeekMasher GeekMasher disabled auto-merge June 18, 2025 15:51
@GeekMasher GeekMasher merged commit d44073e into main Jun 18, 2025
10 checks passed
@GeekMasher GeekMasher deleted the sarif-updates branch June 18, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants