Fix workflow documentation #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves: advanced-security#227 The documented workflow fails to upload the SARIF file because it references the wrong property, causing the file not to be found. This update corrects that issue.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a documentation issue in the workflow example where the SARIF file upload was failing due to incorrect property references. The fix ensures the workflow properly uploads CodeQL analysis results.
- Updates the step ID from
codeql_iactocodeqlfor consistency - Corrects the SARIF file reference from
sariftosarif-resultsto match the actual output property - Adds configuration to preserve the CodeQL tool name in SARIF output
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GeekMasher
approved these changes
Sep 27, 2025
felickz
reviewed
Sep 27, 2025
Clarify comment regarding tool name display for CodeQL.
felickz
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves: #227
The documented workflow fails to upload the SARIF file because it references the wrong property, causing the file not to be found. This update corrects that issue.