Add snapshot correlator action input #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitulisca
requested review from
GeekMasher and
adrienpessu
and removed request for
a team
|
This looks good to me @gitulisca but it seems the CI tests are failing. Let me know when you've updated the tests / verified the issue |
Could this possibly be a flaky? |
brrygrdn
approved these changes
Apr 7, 2025
GeekMasher
approved these changes
Apr 7, 2025
|
@gitulisca that's old. Absolutely it seems to be flakey so let's get it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating as a replacement for PR99 which was approved but couldn't be merged due to a broken CodeQL workflow unrelated to the original PR; creating a new PR was chosen in favor of fixing the existing one with an empty commit
This change will add an action input parameter called correlator which allows for specifying a custom snapshot correlator value.
Using a custom snapshot correlator value is useful when the action is used in a workflow that has a matrix and when it is used on a reusable workflow that targets different paths in a mono repo.
It also provides for extra flexibility that may be required in other use cases when the job id isn't the most appropriate choice for the correlator value .