Skip to content

Remove Leading Slash From Root Manifests #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 9, 2025
Merged

Remove Leading Slash From Root Manifests #125

merged 12 commits into from
Jul 9, 2025

Conversation

ljones140
Copy link
Contributor

@ljones140 ljones140 commented Jul 9, 2025 •
edited
Loading

  • removes the leading slashes for root level manifests.

    • Static manifest parsing and other detectors do not create them.
    • It makes retrieving dependencies for manifests difficult.

  • Updates tests

    • Ensure no root manifests have leading slashes
    • Adds a nested manifest to testdata and tests slashes on other paths are as expected
    • Adds a test that generates output and tests all manifest names are ok

    Closes: Manifests have mismatching file paths compared to GitHub auto-detection #66

@ljones140 ljones140 marked this pull request as ready for review July 9, 2025 12:37
@ljones140 ljones140 requested review from a team as code owners July 9, 2025 12:37
@ljones140 ljones140 requested review from adrienpessu and aegilops and removed request for a team July 9, 2025 12:37
@ljones140 ljones140 mentioned this pull request Jul 9, 2025
Closed
@ljones140 ljones140 merged commit 6dd7b2d into main Jul 9, 2025
5 checks passed
@ljones140 ljones140 deleted the ljones140/remove-manifest-leading-slash branch July 9, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanIakovlev RomanIakovlev RomanIakovlev approved these changes

@adrienpessu adrienpessu Awaiting requested review from adrienpessu adrienpessu is a code owner automatically assigned from advanced-security/oss-maintainers

@aegilops aegilops Awaiting requested review from aegilops aegilops is a code owner automatically assigned from advanced-security/oss-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifests have mismatching file paths compared to GitHub auto-detection
2 participants
@ljones140 @RomanIakovlev