Conversation
…set. Other refactoring
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for operating on a subset of organizations rather than all organizations in an enterprise, along with adding progress flags and refactoring common file reading functionality. The key improvements enable more targeted promotion/demotion operations and better user experience through optional progress output.
- Added ability to filter organizations using
--orgsor--orgs-filearguments - Added
--progressflags to show optional detailed progress information during operations - Refactored file reading logic into a common
read_linesutility function
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/util.py | Added logging support and new read_lines utility function for reading line-separated files |
| org-admin-promote.py | Added organization filtering options and progress flag, updated to use subset filtering |
| org-admin-demote.py | Added progress flag and refactored to use common read_lines utility |
| manage-sec-team.py | Added progress flag and refactored to use common read_lines utility |
| README.md | Updated documentation to reflect new filtering and progress options |
Comments suppressed due to low confidence (2)
manage-sec-team.py:1
- The removal operation on line 189 should respect the progress flag like other operations in this function. Consider wrapping this LOG.info call with
if progress:to maintain consistency.
#!/usr/bin/env python3
manage-sec-team.py:1
- The team member addition operation on line 203 should respect the progress flag like other operations in this function. Consider wrapping this LOG.info call with
if progress:to maintain consistency.
#!/usr/bin/env python3
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.