Skip to content

Takes org list for promotion, filters orgs updated/output by this subset. Other refactoring#27

Merged
aegilops merged 4 commits intomainfrom
promote-subset-orgs
Sep 11, 2025
Merged

Takes org list for promotion, filters orgs updated/output by this subset. Other refactoring#27
aegilops merged 4 commits intomainfrom
promote-subset-orgs

Conversation

@aegilops
Copy link
Copy Markdown
Contributor

No description provided.

@aegilops aegilops requested a review from Copilot September 11, 2025 10:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for operating on a subset of organizations rather than all organizations in an enterprise, along with adding progress flags and refactoring common file reading functionality. The key improvements enable more targeted promotion/demotion operations and better user experience through optional progress output.

  • Added ability to filter organizations using --orgs or --orgs-file arguments
  • Added --progress flags to show optional detailed progress information during operations
  • Refactored file reading logic into a common read_lines utility function

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/util.py Added logging support and new read_lines utility function for reading line-separated files
org-admin-promote.py Added organization filtering options and progress flag, updated to use subset filtering
org-admin-demote.py Added progress flag and refactored to use common read_lines utility
manage-sec-team.py Added progress flag and refactored to use common read_lines utility
README.md Updated documentation to reflect new filtering and progress options
Comments suppressed due to low confidence (2)

manage-sec-team.py:1

  • The removal operation on line 189 should respect the progress flag like other operations in this function. Consider wrapping this LOG.info call with if progress: to maintain consistency.
#!/usr/bin/env python3

manage-sec-team.py:1

  • The team member addition operation on line 203 should respect the progress flag like other operations in this function. Consider wrapping this LOG.info call with if progress: to maintain consistency.
#!/usr/bin/env python3

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aegilops aegilops merged commit 52067f7 into main Sep 11, 2025
7 checks passed
@aegilops aegilops deleted the promote-subset-orgs branch September 11, 2025 13:27
@aegilops aegilops restored the promote-subset-orgs branch September 11, 2025 13:27
@aegilops aegilops deleted the promote-subset-orgs branch September 11, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants