Skip to content

fix(ci): align android bench build policy#74

Merged
adybag14-cyber merged 1 commit intomainfrom
fs55-ethernet-integration
Mar 21, 2026
Merged

fix(ci): align android bench build policy#74
adybag14-cyber merged 1 commit intomainfrom
fs55-ethernet-integration

Conversation

@adybag14-cyber
Copy link
Owner

@adybag14-cyber adybag14-cyber commented Mar 21, 2026

Summary by CodeRabbit

  • Chores
    • Optimized benchmark build configuration for Android ARM targets to enable single-threaded mode, ensuring consistency with the main runtime behavior across this platform combination.

@adybag14-cyber adybag14-cyber merged commit c8a99a5 into main Mar 21, 2026
16 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a2827942-d437-48bd-929d-cf65701833fc

📥 Commits

Reviewing files that changed from the base of the PR and between 9055bad and 4363f7e.

📒 Files selected for processing (1)
  • build.zig

📝 Walkthrough

Walkthrough

Added conditional compilation configuration for the benchmark module in the build script. When targeting Linux with Android ABI on ARM architecture, the benchmark module is now configured to run single-threaded, mirroring the existing root module behavior.

Changes

Cohort / File(s) Summary
Build Configuration
build.zig
Added conditional single-threaded configuration for benchmark_module when targeting Android ARM on Linux, maintaining consistency with root_module setup.

Poem

🐰 A benchmark hops with lighter feet,
On Android ARM, single-threaded and neat!
The builder's wisdom grows with care,
Mirrored configurations everywhere,
One rabbit cheers—consistency's rare! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fs55-ethernet-integration

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant