Open
Conversation
Any change to the environment that happens in the context of `system` only affects the process spawned by `system`, not the main ruby process. The only way to alter the environment of the ruby process is to modify the `ENV` hash. It's unclear if that is necessary, since the existing code wasn't actually doing anything.
It's unclear to me what the rationale for this warning is, but std_cmake_parameters is a method call and its value cannot be mutated.
I'm not sure if the nil here is accidental.
Calling ENV.x11 manually does not enforce the X11 dependency and is no longer supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a few merge conflicts between the current head and @jacknagel's "best practices" head. The whole PR is pretty much an updated version of #44, which was abandoned after a year of no maintenance and review. I figured you might want to merge it some time along.
Thanks,
The @EtherTyper