Skip to content

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Oct 24, 2025

Description

Summary

When using multiple IPs in FORWARDED_ALLOW_IPS variable, request.client.host can be something else than an IP address string and will be wrongly parsed by Redis, implying an error and refusing the connection.

Changes Made

  • Force input data type to string

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

  • ✨ New feature (non-breaking change which adds functionality)

  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)

  • 🔧 Infra CI/CD (changes to configs of workflows)

  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)

  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes

  • Single module changes

  • Multiple modules changes

  • Database migrations required

  • Other:

Testing

  • 1. Tested this locally

  • 2. Added/modified tests that pass the CI

  • 3. Tested in a pre-prod

  • 0. Untestable (exceptionally), will be tested in prod directly
    Error condition are uncertain and can't be reproduced

Documentation

  • Updated the docs accordingly :

  • " Docstrings

  • # Inline comments

  • No documentation needed

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.80%. Comparing base (81b6e15) to head (4a72713).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files         190      190           
  Lines       14600    14600           
=======================================
  Hits        12527    12527           
  Misses       2073     2073           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu merged commit 7e98d98 into main Nov 3, 2025
8 checks passed
@Marc-Andrieu Marc-Andrieu deleted the redis-limiter-fix branch November 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants