Skip to content

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Nov 1, 2025

Description

Summary

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

  • ✨ New feature (non-breaking change which adds functionality)

  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)

  • 🔧 Infra CI/CD (changes to configs of workflows)

  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)

  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes

  • Single module changes

  • Multiple modules changes

  • Database migrations required

  • Other:

Testing

  • 1. Tested this locally

  • 2. Added/modified tests that pass the CI

  • 3. Tested in a pre-prod

  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :

  • " Docstrings

  • # Inline comments

  • No documentation needed

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 87.60331% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.88%. Comparing base (81b6e15) to head (d137e6a).

Files with missing lines Patch % Lines
app/core/myeclpay/endpoints_myeclpay.py 74.04% 34 Missing ⚠️
app/core/myeclpay/cruds_myeclpay.py 91.11% 4 Missing ⚠️
app/core/myeclpay/exceptions_myeclpay.py 66.66% 2 Missing ⚠️
app/core/myeclpay/schemas_myeclpay.py 96.61% 2 Missing ⚠️
app/core/myeclpay/dependencies_myeclpay.py 93.33% 1 Missing ⚠️
app/core/myeclpay/utils_myeclpay.py 88.88% 1 Missing ⚠️
app/types/websocket.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   85.80%   85.88%   +0.08%     
==========================================
  Files         190      193       +3     
  Lines       14600    14952     +352     
==========================================
+ Hits        12527    12842     +315     
- Misses       2073     2110      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants