Sidebar should only show parent resources#27
Merged
rambleraptor merged 5 commits intomainfrom Aug 19, 2025
Merged
Conversation
|
|
||
| parents(): string[] { | ||
| const resource = this.schema["x-aep-resource"] | ||
| if ('parents' in resource) { |
Member
There was a problem hiding this comment.
could you just do resource.parents || []?
| } | ||
|
|
||
| parentResources(): ResourceSchema[] { | ||
| return this.resources().filter((resource) => resource.parents().length == 0); |
Member
There was a problem hiding this comment.
Suggested change
| return this.resources().filter((resource) => resource.parents().length == 0); | |
| return this.resources().filter((resource) => resource.parents().length != 0); |
Shouldn't this be values of non-zero length?
Member
There was a problem hiding this comment.
ah ok, by "parent" are you referring to resources that have no parents? I'd argue that "root" resources are are a better way to describe that.
A parent is a specific relationship to other resources, it's a little confusing to use that in the context of "resources without a parent".
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks! I think the code itself is correct, but I worry about the usage of the term "parent' here. Please see my comments.
Member
|
Here's a PR on a proposal for defining the term "root resource" wdyt? aep-dev/aeps#273 |
rambleraptor
force-pushed
the
sidebar_only_parents
branch
from
b749d76 to
922e79a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #26 #20
This PR adds the following: