-
Notifications
You must be signed in to change notification settings - Fork 4
Add linting rules for AEP-126: Enumerations #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shakrav2
wants to merge
5
commits into
aep-dev:main
Choose a base branch
from
shakrav2:feature/aep-126
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
196ba23
Add AEP-126 linting rules
shakrav2 2f3e3ae
Add field names and OpenAPI 3.1 support to AEP-126 nullable enum rules
shakrav2 0ecafa4
Fix Prettier formatting and ESLint line-length violations
shakrav2 b3b89b0
Fix aep-126-enum-type-string to support OAS 3.1 type arrays
shakrav2 475302f
Apply suggestions from code review
mkistler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| functionsDir: ../functions | ||
| functions: | ||
| - aep-126-enum-case-consistent | ||
| - aep-126-enum-null-first | ||
| - aep-126-enum-nullable-declaration | ||
| - aep-126-no-standard-value-enums | ||
|
|
||
| rules: | ||
| aep-126-enum-type-string: | ||
| description: Enumerated fields should use type string, not integer or other types. | ||
| message: Enum field "{{property}}" should have type "string", not "{{error}}". | ||
| severity: error | ||
| formats: ['oas2', 'oas3'] | ||
| given: $..[?(@property === 'enum')]^ | ||
| then: | ||
| field: type | ||
| function: schema | ||
| functionOptions: | ||
| schema: | ||
| oneOf: | ||
| - const: string | ||
| - type: array | ||
| contains: | ||
| const: string | ||
| maxItems: 2 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess |
||
|
|
||
| aep-126-enum-case-consistent: | ||
| description: All enum values in a field should use consistent case format. | ||
| message: '{{error}}' | ||
| severity: warn | ||
| formats: ['oas2', 'oas3'] | ||
| given: $..[?(@property === 'enum')]^ | ||
| then: | ||
| function: aep-126-enum-case-consistent | ||
|
|
||
| aep-126-enum-null-first: | ||
| description: If enum is nullable, null should be the first value in the enum array. | ||
| message: '{{error}}' | ||
| severity: warn | ||
| formats: ['oas3'] | ||
| given: $..[?(@property === 'enum')]^ | ||
| then: | ||
| function: aep-126-enum-null-first | ||
|
|
||
| aep-126-enum-nullable-declaration: | ||
| description: If enum contains null, field must declare nullable true. | ||
| message: '{{error}}' | ||
| severity: error | ||
| formats: ['oas3'] | ||
| given: $..[?(@property === 'enum')]^ | ||
| then: | ||
| function: aep-126-enum-nullable-declaration | ||
|
|
||
| aep-126-no-standard-value-enums: | ||
| description: Fields should not enumerate standard codes (language, country, currency, media types). | ||
| severity: warn | ||
| formats: ['oas2', 'oas3'] | ||
| given: | ||
| - $..properties[[?(@property == 'language' || @property == 'language_code')]] | ||
| - $..properties[[?(@property == 'country' || @property == 'country_code' || @property == 'region_code')]] | ||
| - $..properties[[?(@property == 'currency' || @property == 'currency_code')]] | ||
| - $..properties[[?(@property == 'media_type' || @property == 'content_type')]] | ||
| then: | ||
| function: schema | ||
| functionOptions: | ||
| schema: | ||
| type: object | ||
| not: | ||
| required: ['enum'] | ||
|
|
||
| aep-126-enum-has-description: | ||
| description: Enum fields should include a description explaining their purpose. | ||
| message: Enum field "{{property}}" should have a description. | ||
| severity: info | ||
| formats: ['oas2', 'oas3'] | ||
| given: $..[?(@property === 'enum')]^ | ||
| then: | ||
| field: description | ||
| function: truthy | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is used in multiple
givens, it seems like a good candidate for an alias.