feat(3): add terminology for root resources and collections #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are missing a term to describe a resource whose collection has no parents. Since this is helpful for things like building a navigation tree, define the term.
rofrankel
requested changes
Jan 24, 2025
Co-authored-by: Richard Frankel <richard@frankel.tv>
Member
Author
|
@rofrankel thanks! ready for another review. |
rofrankel
reviewed
Feb 3, 2025
rofrankel
approved these changes
Feb 21, 2025
Co-authored-by: Richard Frankel <richard@frankel.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing a term to describe a resource whose collection has no parents. Since this is helpful for things like building a navigation tree, define the term.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)💝 Thank you!