Change lint to use command #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegagne
reviewed
Oct 29, 2025
thegagne
reviewed
Oct 29, 2025
toumorokoshi
approved these changes
Oct 30, 2025
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
thanks! fwiw I would prefer to use make here, but a single entry point regardless is good.
Member
Author
|
Yeah, make is the better tool to use. I'll update this and then resolve the merge conflict. We still need package.json / "npm run lint" to ensure we can pin prettier versions. We're running into a lot of lint issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a linter command that runs prettier and our Python scripts. Ensures CI uses them both.