Skip to content

Connection button validation #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bhavan23 merged 2 commits into from
Mar 11, 2026
Merged

Connection button validation #132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c8f63
feat: add validation for service api
l0gesh29 Mar 11, 2026
0c40742
chore: remove depends on
l0gesh29 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions india_banking/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
"Payment Order": "india_banking.overrides.payment_order.CustomPaymentOrder",
}

override_doctype_dashboards = {
"Bank Account": "india_banking.india_banking.doc_events.bank_account.bank_account.get_data"
}

doc_events = {
"Bank": {
Expand Down
14 changes: 14 additions & 0 deletions india_banking/india_banking/doc_events/bank_account/bank_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@
NAME_PATTERN = re.compile(r"^[A-Za-z0-9]+(?: [A-Za-z0-9]+)*$")


def get_data(data=None):
if data is None:
data = {}

data.setdefault("transactions", []).append(
{"label": _("Connector"), "items": ["India Banking Connector"]}
)
data.setdefault("non_standard_fieldnames", {})[
"India Banking Connector"
] = "bank_account"

return data


def validate(doc, method=None):
"""Validate Bank Account document before saving"""
strip_whitespace(doc)
Expand Down
22 changes: 21 additions & 1 deletion india_banking/india_banking/doctype/india_banking_connector/india_banking_connector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"api_key",
"api_secret",
"bulk_transaction",
"service_subscriptions_section",
"fetch_bank_balance",
"fetch_bank_statement",
"payment_configuration_tab",
"enqueue_large_payments_in_the_background",
"enqueue_payments_threshold",
Expand Down Expand Up @@ -252,11 +255,28 @@
"fieldtype": "Datetime",
"label": "Last Execution",
"read_only": 1
},
{
"fieldname": "service_subscriptions_section",
"fieldtype": "Section Break",
"label": "Service Subscriptions"
},
{
"default": "0",
"fieldname": "fetch_bank_balance",
"fieldtype": "Check",
"label": "Fetch Bank Balance"
},
{
"default": "0",
"fieldname": "fetch_bank_statement",
"fieldtype": "Check",
"label": "Fetch Bank Statement"
}
],
"index_web_pages_for_search": 1,
"links": [],
"modified": "2026-03-10 09:12:36.432674",
"modified": "2026-03-11 12:33:36.394960",
"modified_by": "Administrator",
"module": "India Banking",
"name": "India Banking Connector",
Expand Down
18 changes: 16 additions & 2 deletions india_banking/public/js/bank_account.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,22 @@ frappe.ui.form.on("Bank Account", {
},
add_bank_custom_buttons(frm) {
if (!frm.doc.__islocal) {
frm.events.add_balance_fetch_button(frm);
frm.events.add_statements_fetch_button(frm);
let balance_service_subscribed = false;
frappe.db
.get_value("India Banking Connector", frm.doc.name, [
"fetch_bank_balance",
"fetch_bank_statement",
])
.then((r) => {
if (r.message) {
if (r.message.fetch_bank_balance) {
frm.events.add_balance_fetch_button(frm);
balance_service_subscribed = true;
}
if (r.message.fetch_bank_statement) frm.events.add_statements_fetch_button(frm);
}
if (!balance_service_subscribed) frm.set_df_property("bank_balance", "hidden", 1);
});
}
},
add_balance_fetch_button(frm) {
Expand Down