AGDIGGER-59 trigger jenkins job - 2 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @wtrocki @matzew @josemigallas |
| .build(); | ||
| } | ||
|
|
||
| public static DiggerClientBuilder builder() { |
There was a problem hiding this comment.
IMO there's no point on having this method since DiggerClientBuilder is already public.
There was a problem hiding this comment.
Well, right..
I personally think that DiggerClient.builder().foo().bar().build() is more fluent than new DiggerClientBuilder().foo().bar().build().
I am inspired by Guava in this idea.
I prefer keeping it for now, unless more objections arise.
wtrocki
reviewed
Dec 12, 2016
|
|
||
| Build a customized client: | ||
| ``` | ||
| DiggerClient client = DiggerClient.builder() |
wtrocki
reviewed
Dec 12, 2016
| } | ||
|
|
||
| public static class DiggerClientBuilder { | ||
| private JenkinsAuth auth; |
There was a problem hiding this comment.
Like it. That would be easy to test.
wtrocki
approved these changes
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2