Open
Conversation
Multiple decimal point issue is fixed now. Only accepts the initial decimal point others are ignored. recognizing the initial ".X" as "X." is fixed now. Now it takes the value as "0.X"
Contributor
|
I think it would be better to make the fix in a place where it works well for both CLI & GUI and also to prevent the user from making any decisions till he keeps only 1 decimal point. am i right@8hantanu ?!! |
Author
I think input validation and restricting invalid inputs should be done at GUI level. Because in CLI we don't have other option rather than handling an exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple decimal point issue is fixed now. Only accepts the initial decimal point others are ignored.
recognizing the initial ".X" as "X." is fixed now. Now it takes the value as "0.X"