-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-2468] Revamp index creation API #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliannguyen4
wants to merge
38
commits into
dev
Choose a base branch
from
CLIENT-2468-revamp-index-create-api
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+438
−484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bb0d29 to
b696c61
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #505 +/- ##
==========================================
- Coverage 83.55% 82.18% -1.37%
==========================================
Files 99 99
Lines 14438 14416 -22
==========================================
- Hits 12063 11848 -215
- Misses 2375 2568 +193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ex-create-api # Conflicts: # doc/aerospike.rst # doc/client.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make creating secondary indices with a list of contexts simpler:
client.index_<type>_create()methods into oneclient.index_single_value_create()method that takes in actxparameter. As a result, these are now deprecated:ctxparameter toclient.index_map_keys_create(),client.index_map_values_create(), andclient.index_list_create(). As a result,client.index_cdt_create()is now deprecated.Implementation details
createIndexWithCollectionType()helper that was used byclient.index_list_create(),client.index_map_keys_create(), andclient.index_map_values_create()with a new helpercreate_index_with_known_index_type. The latter is an improvement because it handles the argument parsing for all of those API calls, as well as the newclient.index_single_value_create().createIndexWithDataAndCollectionType()since bothcreate_index_with_known_index_type()andclient.index_cdt_create()call that helper to create an index.Extra changes
6cc6ff6
…rectly to an integer variable
Docs
https://aerospike-python-client--505.org.readthedocs.build/en/505/client.html#index-operations
TODO