[CLIENT-2740] Fix bug where LOG_LEVEL_OFF causes more logs to be produced (as if LOG_LEVEL_TRACE was set) #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for None parameter in set_log_handler Added a loggging example
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #572 +/- ##
==========================================
+ Coverage 83.31% 83.55% +0.23%
==========================================
Files 99 99
Lines 14423 14438 +15
==========================================
+ Hits 12017 12063 +46
+ Misses 2406 2375 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added test coverage for missing coverage lines
* [CLIENT-3793] Remove macOS 13 support (#846) * Auto-bump version to 18.1.0rc3.dev1 [skip ci] * [CLIENT-3106] Remove dead code in conversions.c (#817) - record_to_resultpyobject() was a helper function for client.batch_get_ops(), which is now removed. - record_to_pyobject_cnvt_list_to_map() and as_list_of_map_to_py_tuple_list(): these were helper functions that were used before Python client version 2.1.3 to return the result of certain map operations. They are no longer used starting from Python client 2.1.3 and higher, so it is safe to remove - bin_strict_type_checking() isn't used anywhere. But it would be good to consolidate the bin checking code into one place, since it is currently spread out all over the codebase - as_batch_read_results_to_pyobject() was used by get_many() which has been removed - batch_read_records_to_pyobject() was used by select_many() which has been removed Extra Changes Merge do_*_to_pyobject() methods into their calling methods, since they have the same function signature * Auto-bump version to 18.1.0rc3.dev2 [skip ci] --------- Co-authored-by: Julian Nguyen <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Conflicts: # .github/workflows/stage-tests.yml # README.rst # VERSION
….set_log_level. Remove code example since we already have top level example
…p track of whether LOG_LEVEL_OFF is set to simplify
…on decides to use block buffering for stdout
juliannguyen4
changed the title
juliannguyen4
changed the title
dwelch-spike
requested changes
Jan 29, 2026
Contributor
dwelch-spike
left a comment
dwelch-spike
left a comment
There was a problem hiding this comment.
Looking good, mainly want to make sure that the custom logging handler ref counting is correct. See comments.
Collaborator
|
The sphinx linkcheck is failing due to false positives, not related to this PR |
Co-authored-by: dwelch-spike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes:
TODO
potential memory leak inAerospike_Set_Log_Handlerwhere replacing an existing log handler will cause a ref count leakDocs
https://aerospike-python-client--572.org.readthedocs.build/en/572/aerospike.html#