Added Partyfunctions and Teleport Variables #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
You might want to check some things. Your |
Contributor
Author
|
Ah... looks like I had one of the previous versions open when I looked up the positions for Journal. mea culpa.
|
Haselnussbomber
requested changes
Jan 31, 2026
Collaborator
Haselnussbomber
left a comment
Haselnussbomber
left a comment
There was a problem hiding this comment.
A couple notes from me.
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyPartyMember.cs
Outdated
Show resolved
Hide resolved
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyPartyInvite.cs
Outdated
Show resolved
Hide resolved
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyPartyInvite.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
Contributor
Author
Thank you! I added your fixes and suggested changes. The vfunc of InfoProxyInvitedList got me really confused when I found it. At first I put it there, but wasn't so sure afterwards and moved it InfoProxyPartyInvite... Hopefully everything got solved now |
pohky
requested changes
Feb 2, 2026
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyPartyMember.cs
Outdated
Show resolved
Hide resolved
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyPartyMember.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
Co-authored-by: pohky <1510568+pohky@users.noreply.github.com>
pohky
approved these changes
Feb 3, 2026
FFXIVClientStructs/FFXIV/Client/UI/Info/InfoProxyInvitedList.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is correct so far.