Keep the camera position when switching to inspector (fix #607)#717
Merged
dmarcos merged 4 commits intoaframevr:masterfrom Feb 7, 2025
Merged
Keep the camera position when switching to inspector (fix #607)#717dmarcos merged 4 commits intoaframevr:masterfrom
dmarcos merged 4 commits intoaframevr:masterfrom
Conversation
Contributor
Author
|
But it should be an option somehow. I want that behavior when I am on a scene and I open the inspector. aframe-inspector/src/lib/cameras.js Lines 45 to 46 in 575c910 Those positions should also be configurable, with the ortho cameras as well. I'm writing some configurators where I want different camera positions. |
7aac171 to
afdf042
Compare
…e behavior of keeping the camera position in sync
c0b53b4 to
593b5a2
Compare
Contributor
Author
|
I made the new behavior of keeping the inspector perspective camera position in sync with the A-Frame active camera the default, with the ability to disable that behavior with a window.AFRAME_INSPECTOR_CONFIG variable. |
This was referenced Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the camera position and rotation when opening the inspector.
I have this change for quite some times in my project. When I use the default inspector build in other projects I am so frustrated that the camera position is not kept while opening the inspector.
It seems I am not the only one that wanted this behavior.
This closes #607