Skip to content

Fix cloneEntity to also change id on children #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 1 commit into from
Jan 25, 2025
Merged

Fix cloneEntity to also change id on children #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/lib/entity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,16 @@ function insertAfter(newNode, referenceNode) {
}
}

function recursivelyRegenerateId(element) {
if (element.id) {
element.id = getUniqueId(element.id);
}

for (const child of element.childNodes) {
recursivelyRegenerateId(child);
}
}

/**
* Clone an entity, inserting it after the cloned one.
* @param {Element} entity Entity to clone
Expand All @@ -123,10 +133,8 @@ export function cloneEntity(entity) {
{ once: true }
);

// Get a valid unique ID for the entity
if (entity.id) {
clone.id = getUniqueId(entity.id);
}
// Get a valid unique ID for the entity and children
recursivelyRegenerateId(clone);
insertAfter(clone, entity);
}

Expand Down