Some optimizations in SceneGraph code#809
Merged
dmarcos merged 3 commits intoaframevr:masterfrom Jun 21, 2025
Merged
Conversation
vincentfretin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break the for loop when entity is found in SceneGraph selectEntity
No need to still iterate over entities and do a comparison if we found the entity.
I found that when converting this React code to Solid via Claude 4, I figured I push that optimization in here as well.
In scenegraph/Entity.js, simplify getting visible property, it's okay to always use
entity.object3D.visible, not need to check if it's a-scene.