Use child-attached/child-detached events to update SceneGraph#810
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jun 21, 2025
Merged
Use child-attached/child-detached events to update SceneGraph#810dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
… entity is created by a component (fix aframevr#756)
vincentfretin
force-pushed
the
child-attached-detached
branch
from
5c0a826 to
f2121b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use child-attached/child-detached events to update SceneGraph when an entity is created by a component (fix #756)
If you want to test that chane, remove the environment component and add it back, it now properly refreshes the scene graph, removing the children and adding them back respectively.