Cursor component: remove addWebXREventListeners/removeWebXREventListeners in update

[vincentfretin]

Description:

Those calls were introduced in 655ab16
If you set cursor="rayOrigin: xrselect", it calls addWebXREventListeners in update and then in onEnterVR, so adding the listeners twice.
Later if you update a property that is not rayOrigin like fuse, it will call addWebXREventListeners and right away removeWebXREventListeners, so registering and unregistering listeners, it doesn't make sense.

Changes proposed:

• Remove addWebXREventListeners/removeWebXREventListeners from update, only keep addWebXREventListeners in onEnterVR, and the removeWebXREventListeners in removeEventListeners that is called in pause/remove.

I tested that on Android examples/showcase/ui/index.html with <a-scene xr-mode-ui="XRMode: xr" and cursor="rayOrigin: xrselect; fuse: false". When I click on AR button, touching the image opens the modal correctly.
Am I missing something @mrxz?

[mrxz]

The first guard should already prevent adding and removing the event listeners in the same update. Effectively there should only be two possible scenarios:

• No active XRsession when cursor is created, update does not add WebXR event listeners (addWebXREventListeners is a no-op without xrSession), upon onEnterVR they are added
• Entering VR session before creating cursor so not added in onEnterVR, upon creation they are added in update

The general idea behind the logic is to handle the cases a cursor is created or has its rayOrigin changed during an XR session. Instead of removing the logic, it should consider both xrselect and entity instead of just xrselect, similar to your fix in #5622.

[vincentfretin]

Okay, it makes sense now. Thanks for the explanation. I'm closing it and I'll change the condition as part of #5622