Layer component: wait referenceSpace to be set before calling initLayer#5626
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jan 12, 2025
Merged
Layer component: wait referenceSpace to be set before calling initLayer#5626dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I got an error
space argument requiredwhen callingxrGLFactory.createQuadLayerhereaframe/src/components/layer.js
Lines 247 to 253 in 6de8119
In
onEnterVR,this.referenceSpaceis set asynchronously viaaframe/src/components/layer.js
Line 369 in 6de8119
that does
aframe/src/components/layer.js
Line 385 in 6de8119
so in my case
createQuadLayerwas called beforethis.referenceSpacewas set.Changes proposed:
this.referenceSpaceto be set before callingthis.initLayer