Skip to content

Comments

Update preghpages/ghpages commands to use recent versions#5627

Merged
dmarcos merged 1 commit intoaframevr:masterfrom
vincentfretin:update-scripts
Jan 21, 2025
Merged

Update preghpages/ghpages commands to use recent versions#5627
dmarcos merged 1 commit intoaframevr:masterfrom
vincentfretin:update-scripts

Conversation

@vincentfretin
Copy link
Contributor

Description:
Update preghpages/ghpages commands to use recent versions without vulnerabilities.
Before:

39 vulnerabilities (14 moderate, 21 high, 4 critical)

After:

24 vulnerabilities (9 moderate, 13 high, 2 critical)

I tested npm run preghpages before and after, there is no change to the gh-pages folder produced.

Similar change also done in aframe-inspector repo: aframevr/aframe-inspector#785

Changes proposed:

  • Remove shx dependency that should have been removed when we moved from browserify to webpack
  • Replace ghpages -p folder by gh-pages -d folder that does exactly the same thing. ghpages is a non maintained wrapper over gh-pages
  • Update replace-in-file package used in the scripts/preghpages.js script

@dmarcos
Copy link
Member

dmarcos commented Jan 21, 2025

Thanks!

@dmarcos dmarcos merged commit 38f5732 into aframevr:master Jan 21, 2025
3 checks passed
@vincentfretin vincentfretin deleted the update-scripts branch January 21, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants