Fix inline link check in docsLint.js script#5731
Merged
dmarcos merged 1 commit intoaframevr:masterfrom May 28, 2025
Merged
Conversation
Member
|
There's a weird fail in the tests |
Contributor
Author
The failure is due to the fact that the script now actually detects (inline) link errors that are currently in the docs. Fixes for these are included in #5730, so once that is merged the test should pass. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
docsLint.jsscript checks relative links to see if the file they point to exists. For inline links this check wasn't performed correctly, causing issue to go unreported. This PR fixes the script.Fixes for incorrect links are incorporated in #5730
Changes proposed: